babel: Clean babel config on babel daemon stop #17685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykholod
force-pushed
the
master-17413
branch
from
b08fd1d to
552c2b7
Compare
ton31337
reviewed
Dec 20, 2024
babeld/babeld.c
Outdated
| diversity_kind = DIVERSITY_NONE; | ||
| diversity_factor = BABEL_DEFAULT_DIVERSITY_FACTOR; | ||
| resend_delay = BABEL_DEFAULT_RESEND_DELAY; | ||
| smoothing_half_life = BABEL_DEFAULT_SMOOTHING_HALF_LIFE; |
There was a problem hiding this comment.
By the way, shouldn't we use change_smoothing_half_life()? I see it's also used to calculate two_to_the_one_over_hl.
There was a problem hiding this comment.
You are right, that's the way to do it. Just fixed that.
When deactivating babel no router babel and later re-enabling it router babel the previous configuration is still in place. Steps to reproduce: - Enable babel - Configure babel - Disable babel with "no router babel" - Verify config Expected correct behavior: No config present Signed-off-by: Yaroslav Kholod <[email protected]>
ykholod
force-pushed
the
master-17413
branch
from
552c2b7 to
58188b5
Compare
Heroyam Slava |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deactivating babel no router babel and later re-enabling it router babel the previous configuration is still in place.
Steps to reproduce:
Expected correct behavior: No config present