bgpd, lib: Use frrstr_time() when using ctime_r() #17684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
force-pushed
the
fix/json_time_no_newline
branch
5 times, most recently
from
8c6fa66 to
fc0bb7e
Compare
mjstapp
reviewed
Dec 20, 2024
newline is not expected to be printed in JSON outputs, e.g.:
```
"lastUpdate":{"epoch":1734490463,"string":"Wed Dec 18 04:54:23 2024\n"
```
Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/json_time_no_newline
branch
from
fc0bb7e to
6dceb6f
Compare
mjstapp
reviewed
Dec 20, 2024
There was a problem hiding this comment.
It looks like there's some mixing here: a) there are some raw calls to ctime_r(), using some time value, and b) there's the existing lib api, that does some arithmetic and then calls ctime_r() on the result. and there are some places in the code where the code can be replaced with (b), but there are also some places where (a) is needed?
…-JSON
For JSON output we don't need newline to be printed.
Before:
```
"lastUpdate":{"epoch":1734490463,"string":"Wed Dec 18 04:54:23 2024\n"
```
After:
```
"lastUpdate":{"epoch":1734678560,"string":"Fri Dec 20 09:09:20 2024"
```
Signed-off-by: Donatas Abraitis <[email protected]>
Replace with time_to_string(). Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/json_time_no_newline
branch
from
6dceb6f to
8f5821e
Compare
mjstapp
approved these changes
Dec 20, 2024
Jafaral
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.