zebra: avoid race between FPM pthread and zebra main pthread in netlink encode/decode #17581
+507
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add several additional route attribute data and accessors to the dplane module. Signed-off-by: Mark Stapp <[email protected]>
added 5 commits
December 5, 2024 09:23
Separate core netlink route message parsing into a new api that uses a dplane ctx to hold the parsed attribute data. Use the new api in two paths: the normal netlink update message parsing path, and in the FPM plugin, which also uses netlink encoding. The FPM route-notificatin code runs in its own pthread, and only needs a subset of the route info that zebra ordinarily develops. This change stops that pthread from accessing zebra's internal data, such as vrfs and ifps, that are not thread-safe. Signed-off-by: Mark Stapp <[email protected]>
Remove a route api that's no longer used after refactoring the netlink and FPM code. Signed-off-by: Mark Stapp <[email protected]>
The netlink route message encode function accessed and used zebra vrfs to produce debug output. That's not thread-safe, and that encode code needs to run in (at least) the dplane pthread and the FPM plugin pthread. Signed-off-by: Mark Stapp <[email protected]>
Remove use of vrf name, which isn't thread-safe. Signed-off-by: Mark Stapp <[email protected]>
Improve a debug when we create a new rib_dest by calling the debug after setting up the dest. Signed-off-by: Mark Stapp <[email protected]>
mjstapp
force-pushed
the
fix_fpm_netlink
branch
from
2f54047 to
9af5425
Compare
|
pushed a fix for CI issues |
|
CI:rerun |
|
doing another full CI run |
|
lot's of formatting issues :( |
|
I think all of the clang reports are about making lines long; we've agreed that we'll permit longer lines in new code for folks who like them, but we won't mandate them from folks who don't?
|
rzalamena
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current FPM dataplane plugin uses some zebra netlink message encode and decode apis. That seems to have been done to avoid duplication - but there are races present because FPM uses its own pthread, the netlink code touches zebra internal datastructures, and that is not thread-safe. This PR attempts to re-work the netlink apis so that they become safe for FPM use.