bgpd: split nexthop-local unchanged peer subgroup #17071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework bgp_route_server_client in a more standard form in order to facilitate the next commut changes. Cosmetic change. Signed-off-by: Louis Scalbert <[email protected]>
Unset enforce-first-as on r3 of bgp_route_server_client to enable the reception of routes on this router. Signed-off-by: Louis Scalbert <[email protected]>
5bb99cc ("bgpd: reset ipv6 invalid link-local nexthop") now resets the link-local when originating and destination peers are not on the same network segment. However, it does not work all the time. The fix compares the 'from' and 'peer' global IPv6 address. However, 'peer' refers to one of the peers of subgroup. The subgroup may contain peers located on different network segment. Split nexthop-local unchanged peer subgroup by network segment. Fixes: 5bb99cc ("bgpd: reset ipv6 invalid link-local nexthop") Signed-off-by: Louis Scalbert <[email protected]>
Test nexthop-local unchanged with route-server. Signed-off-by: Louis Scalbert <[email protected]>
Test nexthop-local unchanged with route-reflector. Signed-off-by: Louis Scalbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5bb99cc ("bgpd: reset ipv6 invalid link-local nexthop") now resets
the link-local when originating and destination peers are not on the
same network segment. However, it does not work all the time.
The fix compares the 'from' and 'peer' global IPv6 address. However,
'peer' refers to one of the peers of subgroup. The subgroup may contain
peers located on different network segment.
Split nexthop-local unchanged peer subgroup by network segment.
Fixes: 5bb99cc ("bgpd: reset ipv6 invalid link-local nexthop")