isisd: fix wrong check for MT commands #17014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` anlan# show run ! interface eth0 ip router isis A exit ! router isis A metric-style narrow <- NOT wide exit ! end anlan (config)# int eth0 anlan (config-if)# no isis topology ipv6-unicast % Configuration failed. Error type: validation Error description: Multi topology IS-IS can only be used with wide metrics ``` The MT commands are mainly controlled by the binded area, not by interface. Currently if there is any MT configuration in the area, `metric-style` must be with the `wide` mode, this requirement is sufficient. So, the unnecessary/wrong check for MT in the interface should be removed. Signed-off-by: anlan_cs <[email protected]>
|
LGTM |
|
ci:rerun |
|
By default, all MT topologies are enabled on interface but are actually enabled when the topology is enabled using: We cannot set narrow with a configured topology. This check is sufficient |
|
@Mergifyio backport stable/10.1 |
|
@Mergifyio backport stable/10.0 |
✅ Backports have been created
|
✅ Backports have been created
|
This was referenced Oct 8, 2024
donaldsharp
added a commit
that referenced
this pull request
Oct 8, 2024
isisd: fix wrong check for MT commands (backport #17014)
donaldsharp
added a commit
that referenced
this pull request
Oct 8, 2024
isisd: fix wrong check for MT commands (backport #17014)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MT commands are mainly controlled by the binded area, not by interface. Currently if there is any MT configuration in the area,
metric-stylemust be with thewidemode, this requirement is sufficient. So, the unnecessary/wrong check for MT in the interface should be removed.