zebra: Fix crash during reconnect #17000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
approved these changes
Oct 4, 2024
|
For the history, can we have a backtrace? |
|
@Mergifyio backport stable/10.1 stable/10.0 stable/9.1 stable/9.0 stable/8.5 stable/8.4 |
✅ Backports have been created
|
|
Sure.
I used |
|
Could you include this into the commit message? |
fsb4000
force-pushed
the
patch-1
branch
2 times, most recently
from
3b62036 to
5c7d7f4
Compare
|
Done |
fpm_enqueue_rmac_table expects an fpm_rmac_arg* as its argument.
The issue can be reproduced by dropping the TCP session using:
ss -K dst 127.0.0.1 dport = 2620
I used Fedora 40 and frr 9.1.2 and I got the gdb backtrace:
(gdb) bt
0 0x00007fdd7d6997ea in fpm_enqueue_rmac_table (bucket=0x2134dd0, arg=0x2132b60) at zebra/dplane_fpm_nl.c:1217
1 0x00007fdd7dd1560d in hash_iterate (hash=0x21335f0, func=0x7fdd7d6997a0 <fpm_enqueue_rmac_table>, arg=0x2132b60) at lib/hash.c:252
2 0x00007fdd7dd1560d in hash_iterate (hash=0x1e5bf10, func=func@entry=0x7fdd7d698900 <fpm_enqueue_l3vni_table>,
arg=arg@entry=0x7ffed983bef0) at lib/hash.c:252
3 0x00007fdd7d698b5c in fpm_rmac_send (t=<optimized out>) at zebra/dplane_fpm_nl.c:1262
4 0x00007fdd7dd6ce22 in event_call (thread=thread@entry=0x7ffed983c010) at lib/event.c:1970
5 0x00007fdd7dd20758 in frr_run (master=0x1d27f10) at lib/libfrr.c:1213
6 0x0000000000425588 in main (argc=10, argv=0x7ffed983c2e8) at zebra/main.c:492
Signed-off-by: Igor Zhukov <[email protected]>
|
once ci finishes we'll get this in. Clearly this is the correct fix |
This was referenced Oct 4, 2024
ton31337
added a commit
that referenced
this pull request
Oct 7, 2024
zebra: Fix crash during reconnect (backport #17000)
ton31337
added a commit
that referenced
this pull request
Oct 7, 2024
zebra: Fix crash during reconnect (backport #17000)
ton31337
added a commit
that referenced
this pull request
Oct 8, 2024
zebra: Fix crash during reconnect (backport #17000)
ton31337
added a commit
that referenced
this pull request
Oct 8, 2024
zebra: Fix crash during reconnect (backport #17000)
ton31337
added a commit
that referenced
this pull request
Oct 8, 2024
zebra: Fix crash during reconnect (backport #17000)
ton31337
added a commit
that referenced
this pull request
Oct 8, 2024
zebra: Fix crash during reconnect (backport #17000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fpm_enqueue_rmac_tableexpects anfpm_rmac_arg *as its argument.The issue can be reproduced by dropping the TCP session using:
I've seen that you have
testsfolder but I'm new to the frr codebase, if you give me small guidelines I can add a test for my PR.