Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Relax the same prefix and nexthop to be valid #16941

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Sep 27, 2024

Closes #16877

@frrbot frrbot bot added bgp bugfix tests Topotests, make check, etc labels Sep 27, 2024
@ton31337 ton31337 changed the title bgpd: Rekax the same prefix and nexthop to be valid if received via iBGP bgpd: Relax the same prefix and nexthop to be valid if received via iBGP Sep 27, 2024
@ton31337 ton31337 force-pushed the fix/issue_16877 branch 2 times, most recently from f1a948a to dc79958 Compare September 27, 2024 20:12
@riw777 riw777 self-requested a review October 1, 2024 15:28
It's replaced and simplified by c3fd1e9.

JSON topo is just horrible to debug.

Signed-off-by: Donatas Abraitis <[email protected]>
Treat as next-hop invalid if import check is enabled.

Fixes: 654a597 ("bgpd: prevent routes loop through itself")

Fixes: FRRouting#16877

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337 ton31337 changed the title bgpd: Relax the same prefix and nexthop to be valid if received via iBGP bgpd: Relax the same prefix and nexthop to be valid Oct 1, 2024
@ton31337 ton31337 added this to the 10.2 milestone Oct 2, 2024
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit 02e5a05 into FRRouting:master Oct 8, 2024
11 checks passed
@ton31337 ton31337 deleted the fix/issue_16877 branch October 8, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IBGP network for loopback not considered valid route when set as neighbor
2 participants