Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospfd: reset spf_hold_multiplier when current SPF delay state is changed #16851

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Shbinging
Copy link
Contributor

@Shbinging Shbinging commented Sep 18, 2024

OSPFD The issue occurs when the new value set using the timers throttle spf command is larger than the previous one. In this case, the holdTimeMultiplier does not reset to 1 and remains greater than 1, leading to an incorrect min_holdtime.

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix frrbot (styling) issues.

@Shbinging Shbinging force-pushed the fix_timer_throttle_spf branch from 31de812 to 4a26e53 Compare September 23, 2024 06:57
@github-actions github-actions bot added the rebase PR needs rebase label Sep 23, 2024
@Shbinging
Copy link
Contributor Author

ok

Copy link
Collaborator

@aceelindem aceelindem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You could put the variable sets in the conditional statements as well though.

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit 849df49 into FRRouting:master Sep 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants