bgpd, lib: Include SID structure in seg6local nexthop #16835
Conversation
Include SID structure information in seg6local nexthop data structure. Signed-off-by: Carmine Scarpitta <[email protected]>
cscarpitta
force-pushed
the
add-sid-structure-to-seg6local-nh
branch
from
d15eda9 to
ec21870
Compare
cscarpitta
changed the title
Include SID structure information when installing an SRv6 End.DT6 or End.DT4 SID in the forwarding plane. Signed-off-by: Carmine Scarpitta <[email protected]>
Include SID structure information when installing an SRv6 End.DT46 SID in the forwarding plane. Signed-off-by: Carmine Scarpitta <[email protected]>
Include SID structure information when removing an SRv6 End.DT4 or End.DT6 SID from the forwarding plane. Signed-off-by: Carmine Scarpitta <[email protected]>
Include SID structure information when removing an SRv6 End.DT46 SID from the forwarding plane. Signed-off-by: Carmine Scarpitta <[email protected]>
cscarpitta
force-pushed
the
add-sid-structure-to-seg6local-nh
branch
from
ec21870 to
1587169
Compare
In the SONiC Routing WG, Donald and SONiC team agreed to host an extended FPM module under SONiC for some features like SRv6. In order to install/remove an SRv6 SID in the SONiC dataplane, this extended FPM module needs to know some locator information. Currently, when a locator is removed in FRR, first zebra frees the locator data structures. Then the extended FPM module under SONiC accesses data structures owned by the master pthread to retrieve the locator information. This operation fails because the locator has already been freed. To fix the issue, Donald proposed to pass all the information needed to install/remove the SID inside the dplane context. This way the extended FPM module no longer needs to access the master pthread's internal data structures that may already have been freed. This PR implements the proposal from Donald. It adds the required locator information to the seg6local_context passed to the FPM module inside the dplane context. This information will be used in the dataplane by the SONiC FPM module. |
|
Got it, thanks for the explanation. |
|
@Mergifyio backport stable/10.1 stable/10.0 stable/9.1 |
✅ Backports have been created
|
Porting of FRRouting/frr#16835 fix Signed-off-by: Carmine Scarpitta <[email protected]>
This PR fixes the SRv6 SID uninstall introduced in this PR: #18715 This fix has been already merged in the FRR mainline: FRRouting/frr#16835 Signed-off-by: Carmine Scarpitta <[email protected]>
This PR fixes the SRv6 SID uninstall introduced in this PR: sonic-net#18715 This fix has been already merged in the FRR mainline: FRRouting/frr#16835 Signed-off-by: Carmine Scarpitta <[email protected]>
This PR fixes the SRv6 SID uninstall introduced in this PR: sonic-net#18715 This fix has been already merged in the FRR mainline: FRRouting/frr#16835 Signed-off-by: Carmine Scarpitta <[email protected]>
Include SID structure information when installing/removing an SRv6 SID in/from the forwarding plane.