Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: include the prefix in nht show command #16828

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

enkechen-panw
Copy link
Contributor

Include the prefix in "show ip nht" and "show ipv6 nht".

vty_out(vty, " resolved via %s\n",
zebra_route_string(rnh->state->type));
vty_out(vty, " prefix %pFX\n", &rnh->resolved_route);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO make the line “ resolved via %s prefix %pFX\n”.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have also added a "," between the protocol and the prefix.

@github-actions github-actions bot added size/M and removed size/S labels Sep 15, 2024
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash to a single commit both changes.

Include the prefix in "show ip nht" and "show ipv6 nht".

Signed-off-by: Enke Chen <[email protected]>
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pguibert6WIND pguibert6WIND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donaldsharp donaldsharp merged commit aab2946 into FRRouting:master Sep 16, 2024
11 checks passed
@enkechen-panw enkechen-panw deleted the print-rnh branch September 16, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants