Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Adjust minimum wait/count timers for run_and_expect() if they are too low #16815

Conversation

ton31337
Copy link
Member

No description provided.

…are too low

If the developer pass way too low timers, we end up with most likely false-positive
situations for random tests under a high load of the system.

It would be better to fallback to the minimum default values for such a cases.

E.g.:

```
WARNING: topo: Waiting time is too small (count=1, wait=0.5), using default values (count=20, wait=3)
```

Signed-off-by: Donatas Abraitis <[email protected]>
@frrbot frrbot bot added the tests Topotests, make check, etc label Sep 13, 2024
@donaldsharp donaldsharp merged commit 5074633 into FRRouting:master Sep 13, 2024
14 checks passed
@ton31337 ton31337 deleted the fix/adjust_wait_count_default_timers_if_too_low branch September 13, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master size/S tests Topotests, make check, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants