bgpd: fix 'nexthop_set failed' error message often displayed #16782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Sep 11, 2024
The 'nexthop_set failed, resetting connection - intf' log message is often seen when peering with BGP peers. This message has been displayed by introducing a recent fix that extracts the IP/port information of outgoing connections when peering is not yet established. Fix this by separating the update of the socket information from the call to bgp_zebra_nexthop_set(). Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
fix_nexthop_set_failed_message
branch
from
c15b645 to
37702ca
Compare
I have a second proposal.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below log message is often seen when peering with BGP peers. This message has been displayed by introducing a recent fix that exposes the IP/port information when available.
Fix this by separating the peer->su_[local/remote] contexts used for display, and for handling the peer session operational.
Two new attributes are appended to the peer structure: su_remote_display and su_local_display. Those fields are only used for display the network information (in vty and in snmp).
Fixes: 78ce639 ("bgpd: fix addressing information of non established outgoing sessions")