bgpd: remove redundant loopback check in label update #16743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "if_is_vrf" check is unnecessary because it’s already handled by "if_get_vrf_loopback". Additionally, it ignores the default loopback and could introduce potential bugs. Fixes: 8b81f32 ("bgpd: fix label lost when vrf loopback comes back") Signed-off-by: Loïc Sang <[email protected]>
ton31337
reviewed
Sep 4, 2024
| @@ -304,7 +304,7 @@ void vpn_leak_zebra_vrf_label_update(struct bgp *bgp, afi_t afi) | |||
|
|
|||
| if (vpn_leak_to_vpn_active(bgp, afi, NULL, false)) { | |||
| ifp = if_get_vrf_loopback(bgp->vrf_id); | |||
| if (ifp && if_is_vrf(ifp) && if_is_up(ifp)) | |||
| if (ifp && if_is_up(ifp)) | |||
There was a problem hiding this comment.
What if this is only a loopback, but not a VRF? if_get_vrf_loopback() can return true if this is only a loopback (default VRF).
There was a problem hiding this comment.
I observed a regression, the "import vpn" command fails to install the bgpd label on the default loopback interface. if_get_vrf_loopback() returns true for VRF and default loopback, the check if_is_vrf() is unnecessary and incorrect, as it ignores the default loopback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "if_is_vrf" check is unnecessary because it’s already handled by "if_get_vrf_loopback". Additionally, it ignores the default loopback and could introduce potential bugs.
Fixes: 8b81f32 ("bgpd: fix label lost when vrf loopback comes back")