Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isisd: Add missing exit statement to show running-config output #16724

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

cscarpitta
Copy link
Contributor

Add missing exit statement to show running-config output.

router isis ISIS_CORE
 is-type level-2-only
 net 49.0001.0000.0000.0004.00
 lsp-mtu 1300
 topology ipv6-unicast
 log-adjacency-changes
 segment-routing srv6
  locator ISIS_LOC
 exit   <<<<<<<<<<<<<<<<<<<<<<<<
exit

Fixes #16694

Add missing `exit` statement to `show running-config` output.

```
router isis ISIS_CORE
 is-type level-2-only
 net 49.0001.0000.0000.0004.00
 lsp-mtu 1300
 topology ipv6-unicast
 log-adjacency-changes
 segment-routing srv6
  locator ISIS_LOC
 exit   <<<<<<<<<<<<<<<<<<<<<<<<
exit
```

Fixes FRRouting#16694

Signed-off-by: Carmine Scarpitta <[email protected]>
@frrbot frrbot bot added the isis label Sep 2, 2024
@cscarpitta cscarpitta changed the title isisd: Add missing exit statement isisd: Add missing exit statement to show running-config output Sep 2, 2024
@ton31337
Copy link
Member

ton31337 commented Sep 3, 2024

@Mergifyio backport stable/10.1 stable/10.0 stable/9.1 stable/9.0

Copy link

mergify bot commented Sep 3, 2024

backport stable/10.1 stable/10.0 stable/9.1 stable/9.0

✅ Backports have been created

@cscarpitta
Copy link
Contributor Author

ci:retry

@SPYFF
Copy link

SPYFF commented Sep 3, 2024

Great, thanks for the prompt fix! :-)

@riw777 riw777 self-requested a review September 3, 2024 15:00
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Sep 3, 2024

rerunning the failed test ... not related :-)

@riw777
Copy link
Member

riw777 commented Sep 3, 2024

failing nhrp tests ... not related, but rerunning to see if I can get this to clear

@ton31337 ton31337 merged commit 3ae49f7 into FRRouting:master Sep 4, 2024
14 checks passed
ton31337 added a commit that referenced this pull request Sep 4, 2024
isisd: Add missing `exit` statement to `show running-config` output (backport #16724)
donaldsharp added a commit that referenced this pull request Sep 4, 2024
isisd: Add missing `exit` statement to `show running-config` output (backport #16724)
donaldsharp added a commit that referenced this pull request Sep 4, 2024
isisd: Add missing `exit` statement to `show running-config` output (backport #16724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segment-routing config loss after frr restart/node reboot
4 participants