bgpd: Do not scan update-groups if default-originate timer is set to 0 #16720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Donatas Abraitis <[email protected]>
With lots of update-groups, subgroups, this could be very tricky and the timer is spawned even if it's totally unnecessary (default-originate is not enabled). Signed-off-by: Donatas Abraitis <[email protected]>
|
do we have other timers that are 0-X and 0 means run it immediately? In other words do we need to go through and make our behavior consistent for all 0 length timers? |
Probably yes, I'll review them separately then. |
If the neighbor is not configured with `neighbor X default-originate route-map ...`, then this timer is useless. Change the logic to be it disabled by default, but enabled automatically once the route-map is configured for default-originate command. Automatically assigned timer value is as before, 5 seconds. Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
deleted the
fix/default_originate_not_needed_if_not_enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.