No connected/local/kernel nexthops at first #16688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldsharp
force-pushed
the
no_connected_nexthops_at_first
branch
from
2e0b97d to
6b26022
Compare
ton31337
reviewed
Aug 30, 2024
zebra/zebra_rib.c
Outdated
| @@ -4483,6 +4490,9 @@ int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type, | |||
| /* Add nexthop. */ | |||
| nexthop = *nh; | |||
| nexthop_group_add_sorted(&ng, &nexthop); | |||
|
|
|||
| //if (type == ZEBRA_ROUTE_CONNECT) | |||
zebra/zebra_rib.c
Outdated
| if (re->type == ZEBRA_ROUTE_CONNECT || | ||
| re->type == ZEBRA_ROUTE_LOCAL || | ||
| re->type == ZEBRA_ROUTE_KERNEL) { | ||
| zlog_debug(" Is a CONNECT OR KERNEL setting flag"); |
Currently the FRR code will receive both kernel and connected routes that do not actually have an underlying nexthop group at all. Zebra turns around and creates a `matching` nexthop hash entry and installs it. For connected routes, this will create 2 singleton nexthops in the dplane per interface (v4 and v6). For kernel routes it would just create 1 singleton nexthop that might be used or not. This is bad because the dplane has a limited amount of space available for nexthop entries and if you happen to have a large number of interfaces then all of a sudden you have 2x(# of interfaces) singleton nexthops. Let's modify the code to delay creation of these singleton nexthops until they have been used by something else in the system. Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
no_connected_nexthops_at_first
branch
from
6b26022 to
8f47dc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating these three types of routes, we are also implicitly creating a nexthop group that matches these routes. If these routes already exist in the kernel using the old style of nexthops there is no need to immediately install these nexthops. Make it so that they initially will
pretendinstall and then when it is really needed install them.