tests: Fix route-scale at higher ecmp #16680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops - looks like there's a python style fix needed? |
mjstapp
reviewed
Aug 28, 2024
| @@ -119,7 +119,7 @@ def run_one_setup(r1, s): | |||
| count = d["rib"] | |||
| break | |||
|
|
|||
| logger.info("Testing {} routes X {} ecmp".format(count, s["ecmp"])) | |||
| logger.info("Testing {} routes X {} ecmp, waiting {} retries {}".format(count, s["ecmp"], wait, retries)) | |||
There was a problem hiding this comment.
looks like this need to be styled?
Recent commits moved the default retries to 60, but the higher ecmp counts were over-riding to 40. Let's make it 80. Noticed this when I went looking at failures on 386 platforms in our ci. Route scale is timing out when deleting routes. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
route_scale_minor_changes
branch
from
46ccc26 to
ce74a6b
Compare
|
something went wrong with the CI. After rerun, all tests passed, but it still shows as failed! going for a 2nd rerun just to make sure |
|
ci:rerun |
|
Merging - don't know what's up with CI today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent commits moved the default retries to 60, but the higher ecmp counts were over-riding to 40. Let's make it 80.
Noticed this when I went looking at failures on 386 platforms in our ci. Route scale is timing out when deleting routes.