doc: Update topotest doc to include iptables is needed #16679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nhrp tests skip tests that do not have iptables installed. As such we have ended up with a situation where the nrhp test is now failing locally for me because I have iptables installed and if the CI system had iptables installed it would have detected the problem as well. Let's document that iptables is needed to do testing. Signed-off-by: Donald Sharp <[email protected]>
mjstapp
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nhrp tests skip tests that do not have iptables installed. As such we have ended up with a situation where the nrhp test is now failing locally for me because I have iptables installed and if the CI system had iptables installed it would have detected the problem as well.
Let's document that iptables is needed to do testing.