mgmtd: Ensure map is NULL #16677
Merged
mgmtd: Ensure map is NULL #16677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build is complaining: build 27-Aug-2024 05:46:38 mgmtd/mgmt_be_adapter.c: In function ‘mgmt_register_client_xpath’: build 27-Aug-2024 05:46:38 mgmtd/mgmt_be_adapter.c:274:27: warning: ‘maps’ may be used uninitialized [-Wmaybe-uninitialized] build 27-Aug-2024 05:46:38 274 | map = darr_append(*maps); build 27-Aug-2024 05:46:38 | ^ build 27-Aug-2024 05:46:38 mgmtd/mgmt_be_adapter.c:250:36: note: ‘maps’ was declared here build 27-Aug-2024 05:46:38 250 | struct mgmt_be_xpath_map **maps, *map; build 27-Aug-2024 05:46:38 | ^~~~ Let's make the compiler happy, even though there is no problem. Signed-off-by: Donald Sharp <[email protected]>
mjstapp
reviewed
Aug 28, 2024
| @@ -249,6 +249,8 @@ static void mgmt_register_client_xpath(enum mgmt_be_client_id id, | |||
| { | |||
| struct mgmt_be_xpath_map **maps, *map; | |||
|
|
|||
| maps = NULL; | |||
|
|
|||
There was a problem hiding this comment.
are we going to get a report down after line 267, because we could be deref'ing maps when it's NULL ?
There was a problem hiding this comment.
all 4 cases that are available are in the switch
enum mgmt_be_xpath_subscr_type {
MGMT_BE_XPATH_SUBSCR_TYPE_CFG,
MGMT_BE_XPATH_SUBSCR_TYPE_OPER,
MGMT_BE_XPATH_SUBSCR_TYPE_NOTIF,
MGMT_BE_XPATH_SUBSCR_TYPE_RPC,
};
I don't see a path that would actually cause this problem, but the compiler is complaining about something that it should not be complaining. I'm just making it happy
mjstapp
approved these changes
Aug 28, 2024
Jafaral
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build is complaining:
build 27-Aug-2024 05:46:38 mgmtd/mgmt_be_adapter.c: In function ‘mgmt_register_client_xpath’: build 27-Aug-2024 05:46:38 mgmtd/mgmt_be_adapter.c:274:27: warning: ‘maps’ may be used uninitialized [-Wmaybe-uninitialized]
build 27-Aug-2024 05:46:38 274 | map = darr_append(*maps);
build 27-Aug-2024 05:46:38 | ^
build 27-Aug-2024 05:46:38 mgmtd/mgmt_be_adapter.c:250:36: note: ‘maps’ was declared here
build 27-Aug-2024 05:46:38 250 | struct mgmt_be_xpath_map **maps, *map;
build 27-Aug-2024 05:46:38 | ^~~~
Let's make the compiler happy, even though there is no problem.