tests: Fix bgp_default_originate_topo1_3 #16673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jafaral
reviewed
Aug 27, 2024
tests/topotests/bgp_default_originate/test_bgp_default_originate_topo1_3.py
Outdated
Show resolved
Hide resolved
ton31337
reviewed
Aug 28, 2024
tests/topotests/bgp_default_originate/test_bgp_default_originate_topo1_3.py
Outdated
Show resolved
Hide resolved
This test was killing bgp on r1 and r2 and then immediately testing that the default route transitioned. Unfortunately the test was written that under load the system might be in a bad state. Let's modify the code to check for a bgp version change and then that the bgp state has come back up Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
default_original_sin
branch
from
a677ac7 to
598d9a1
Compare
ton31337
approved these changes
Aug 28, 2024
|
@Mergifyio backport stable/10.1 stable/10.0 |
✅ Backports have been created
|
This was referenced Aug 30, 2024
Jafaral
added a commit
that referenced
this pull request
Aug 31, 2024
tests: Fix bgp_default_originate_topo1_3 (backport #16673)
donaldsharp
added a commit
that referenced
this pull request
Aug 31, 2024
tests: Fix bgp_default_originate_topo1_3 (backport #16673)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was killing bgp on r1 and r2
and then immediately testing that the
default route transitioned. Unfortunately
the test was written that under load the
system might be in a bad state. Let's
modify the code to check for a bgp version
change and then that the bgp state has
come back up