isisd: fix update link params after circuit is up #16667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the link-params are set when the circuit not yet up, the link-params
are never updated.
isis_link_params_update() is called from isis_circuit_up() but returns
immediately because circuit->state != C_STATE_UP. circuit->state is
updated in isis_csm_state_change after isis_circuit_up().
> struct isis_circuit *isis_csm_state_change(enum isis_circuit_event event,
> struct isis_circuit *circuit,
> void *arg)
> {
> [...]
> if (isis_circuit_up(circuit) != ISIS_OK) {
> isis_circuit_deconfigure(circuit, area);
> break;
> }
> circuit->state = C_STATE_UP;
> isis_event_circuit_state_change(circuit, circuit->area,
> 1);
Do not return isis_link_params_update() if circuit->state != C_STATE_UP.
Fixes: 0fdd8b2 ("isisd: update link params after circuit is up")
Signed-off-by: Louis Scalbert <[email protected]>
|
@Mergifyio backport stable/10.1 stable/10.0 stable/9.1 stable/9.0 stable/8.5 |
✅ Backports have been created
|
This was referenced Sep 3, 2024
donaldsharp
added a commit
that referenced
this pull request
Sep 3, 2024
isisd: fix update link params after circuit is up (backport #16667)
Jafaral
added a commit
that referenced
this pull request
Sep 3, 2024
isisd: fix update link params after circuit is up (backport #16667)
donaldsharp
added a commit
that referenced
this pull request
Sep 3, 2024
isisd: fix update link params after circuit is up (backport #16667)
donaldsharp
added a commit
that referenced
this pull request
Sep 3, 2024
isisd: fix update link params after circuit is up (backport #16667)
ton31337
added a commit
that referenced
this pull request
Sep 4, 2024
isisd: fix update link params after circuit is up (backport #16667)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the link-params are set when the circuit not yet up, the link-params are never updated.
isis_link_params_update() is called from isis_circuit_up() but returns immediately because circuit->state != C_STATE_UP. circuit->state is updated in isis_csm_state_change after isis_circuit_up().
Do not return isis_link_params_update() if circuit->state != C_STATE_UP.
Fixes: 0fdd8b2 ("isisd: update link params after circuit is up")