tests: Allow convergence before adding multicast routes #16656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjstapp
reviewed
Aug 26, 2024
| @@ -25,6 +25,11 @@ | |||
| import datetime | |||
| from time import sleep | |||
| import pytest | |||
| from functools import partial | |||
| import json | |||
Current code adds a new vlan interface, sets up ospf and pim on it and immediately starts shoving data down the pipes. This of course has the fun thing where the IGP and pim do not always come up in a nice neat manner and the test is looking for state from a nice neat come up, even though pim is `working` correctly it is not correct for what the test wants. Modify the code to ensure that ospf is up and has propagated the route where it is needed as well as that pim neighbors have properly come up, then initiate the multicast streams and igmp reports. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
minor_fix_for_pim_dr_nondr
branch
from
397d308 to
3c4ffca
Compare
mjstapp
approved these changes
Aug 26, 2024
|
Will get it in once it passes CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code adds a new vlan interface, sets up ospf and pim on it and immediately starts shoving data down the pipes. This of course has the fun thing where the IGP and pim do not always come up in a nice neat manner and the test is looking for state from a nice neat come up, even though pim is
workingcorrectly it is not correct for what the test wants.Modify the code to ensure that ospf is up and has propagated the route where it is needed as well as that pim neighbors have properly come up, then initiate the multicast streams and igmp reports.