Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: fix labels static-analyser #16655

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

louis-6wind
Copy link
Contributor

Fix static-analyser warnings with BGP labels:

$ scan-build make -j12
bgpd/bgp_updgrp_packet.c:819:10: warning: Access to field 'extra' results in a dereference of a null pointer (loaded from variable 'path') [core.NullDereference]
? &path->extra->labels->label[0]
^~~~~~~~~

Fix static-analyser warnings with BGP labels:

> $ scan-build make -j12
> bgpd/bgp_updgrp_packet.c:819:10: warning: Access to field 'extra' results in a dereference of a null pointer (loaded from variable 'path') [core.NullDereference]
>                                                 ? &path->extra->labels->label[0]
>                                                    ^~~~~~~~~

Signed-off-by: Louis Scalbert <[email protected]>
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-6wind
Copy link
Contributor Author

ci:rerun

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Aug 27, 2024

rerunning just the failed to test to see what we can do with this

@ton31337 ton31337 merged commit 3d2c589 into FRRouting:master Aug 27, 2024
16 checks passed
@ton31337
Copy link
Member

@Mergifyio backport stable/10.1

Copy link

mergify bot commented Aug 27, 2024

backport stable/10.1

✅ Backports have been created

Jafaral added a commit that referenced this pull request Aug 27, 2024
…f55104b18ddc3146089db474_10.1

bgpd: fix labels static-analyser (backport #16655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants