Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Respect BLACKHOLE community for internal BGP peering also #16651

Merged

Conversation

ton31337
Copy link
Member

No description provided.

Copy link
Member

@donaldsharp donaldsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update doc/user/bgp.rst as well?

rfc7999 does not define to use this technique ONLY for EBGP sessions.

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337 ton31337 force-pushed the fix/blackhole_community_bgpd branch from 3b37ce5 to 7a46147 Compare August 27, 2024 07:08
@ton31337
Copy link
Member Author

Can you update doc/user/bgp.rst as well?

Fixed.

@github-actions github-actions bot added size/M and removed size/S labels Aug 27, 2024
@ton31337 ton31337 requested a review from donaldsharp August 27, 2024 07:09
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Aug 27, 2024

@donaldsharp can you clear the blocker? :-)

@donaldsharp donaldsharp dismissed their stale review August 27, 2024 19:10

cause today is tuesday

@donaldsharp donaldsharp merged commit ae49b99 into FRRouting:master Aug 27, 2024
11 checks passed
@ton31337 ton31337 deleted the fix/blackhole_community_bgpd branch August 27, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants