tools, ospfclient: add a config option to skip installing python scripts #16610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Aug 22, 2024
configure.ac
Outdated
| @@ -847,9 +847,12 @@ AC_ARG_WITH([crypto], | |||
| AC_ARG_WITH([frr-format], | |||
| AS_HELP_STRING([--with-frr-format[=<.../frr-format.so>]], [use frr-format GCC plugin])) | |||
|
|
|||
| AC_ARG_ENABLE([version-build-config], | |||
| AC_ARG_ENABLE([version_build_config], | |||
There was a problem hiding this comment.
This seems like unrelated, a separate commit needed?
There was a problem hiding this comment.
It is a pretty minor fix with a rarely used option that doesn't affect functionality at all, I figured I will just sneak it in here.
There was a problem hiding this comment.
yeah I really hate having fixes snuck in with other stuff. If we have to back out one or more this makes it more difficult. I agree with Donatas, put this in a separate commit.
The new config option --disable-python-runtime allows make install to proceed without installing any of the python scripts. When installing from deb/rpm packages those are bundled as frr-pythontools, which is independent from the frr binaries and can already be skipped. I.e, this PR gives the option to skip those scripts when building/installing from sources too. Signed-off-by: Jafar Al-Gharaibeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new config option
--disable-python-runtimeallowsmake installto proceed without installing any of the python scripts. When installing from deb/rpm packages those are bundled asfrr-pythontools, which is independent from the frr binaries and can already be skipped. I.e, this PR gives the option to skip those scripts when building/installing from sources too.