Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add retries to nhg tests in all_proto_startup #16583

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

mjstapp
Copy link
Contributor

@mjstapp mjstapp commented Aug 14, 2024

The all_protocol_startup topotest needs to allow for some delay between configuring nexthop-groups and their installation. Add some wait periods in a couple of nhg test cases.

This should (may) fix several of the failures in this test suite that we've seen recently.

The all_protocol_startup topotest needs to allow for some delay
between configuring nexthop-groups and their installation. Add
some wait periods in a couple of nhg test cases.

Signed-off-by: Mark Stapp <[email protected]>
@mjstapp mjstapp requested a review from donaldsharp August 14, 2024 12:39
@frrbot frrbot bot added the tests Topotests, make check, etc label Aug 14, 2024
@donaldsharp
Copy link
Member

Once CI finishes let's get this in.

@donaldsharp donaldsharp merged commit 28df446 into FRRouting:master Aug 14, 2024
14 checks passed
@mjstapp mjstapp deleted the fix_all_proto_nhg branch September 4, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master size/M tests Topotests, make check, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants