lib: Don't print warning if not a daemon #16542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjstapp
reviewed
Aug 8, 2024
lib/libfrr.c
Outdated
| @@ -1474,3 +1474,11 @@ const char *frr_vers2str(uint32_t version, char *buf, int buflen) | |||
|
|
|||
| return buf; | |||
| } | |||
|
|
|||
| extern bool frr_is_daemon(void) | |||
There was a problem hiding this comment.
some compilers may not like that "extern" in the definition?
vtysh will print out the `stupidly large FD limit` upon every run of the program if the ulimit is set stupidly large. Prevent this from being displayed for vtysh. Fixes: FRRouting#16516 Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
vtysh_stupidly_large
branch
from
2b4efde to
cecf571
Compare
ton31337
reviewed
Aug 9, 2024
|
|
||
| bool frr_is_daemon(void) | ||
| { | ||
| if (di) |
There was a problem hiding this comment.
I think we are looking at our belly button too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vtysh will print out the
stupidly large FD limitupon every run of the program if the ulimit is set stupidly large. Prevent this from being displayed for vtysh.Fixes: #16516