Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Document on how to start specific daemons with unified config in topotests #16534

Merged

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Aug 8, 2024

E.g.:

for _, (rname, router) in enumerate(router_list.items(), 1):
    router.load_frr_config(os.path.join(CWD, "{}/frr.conf".format(rname)))

@frrbot frrbot bot added the tests Topotests, make check, etc label Aug 8, 2024
@ton31337
Copy link
Member Author

ton31337 commented Aug 9, 2024

@Mergifyio rebase

Copy link

mergify bot commented Aug 9, 2024

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@opensourcerouting needs to authorize modification on its head branch.

@ton31337 ton31337 force-pushed the fix/start_ldpd_if_unified branch from 2fef9e9 to b367664 Compare August 9, 2024 10:28
@donaldsharp
Copy link
Member

I saw some new lldp test failures when I looked. Something is awry

@ton31337
Copy link
Member Author

Where do we use lldp?

@ton31337 ton31337 marked this pull request as draft August 11, 2024 08:53
@ton31337 ton31337 force-pushed the fix/start_ldpd_if_unified branch from b367664 to 3901cfe Compare August 11, 2024 10:47
@frrbot frrbot bot added the documentation label Aug 11, 2024
@github-actions github-actions bot added size/S and removed size/XS labels Aug 11, 2024
@ton31337 ton31337 changed the title tests: Start ldpd if unified config is used in topotests doc: Document on how to start specific daemons with unified config in topotests Aug 11, 2024
@ton31337 ton31337 marked this pull request as ready for review August 11, 2024 10:48
@donaldsharp donaldsharp merged commit c4fdc83 into FRRouting:master Aug 12, 2024
13 checks passed
@ton31337 ton31337 deleted the fix/start_ldpd_if_unified branch August 12, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants