mgmtd: don't add implicit state data when reading config from file #16529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mgmt reads configuration from file, it shouldn't add implicit state data to the candidate datastore. Configuration datastores like candidate should never store state, otherwise they fail validation. Fixes FRRouting#15814 Signed-off-by: Igor Ryzhov <[email protected]>
|
I tetsted this fix and it solves the problem |
|
@Mergifyio backport stable/10.1 stable/10.0 |
✅ Backports have been created
|
choppsv1
approved these changes
Aug 10, 2024
This was referenced Aug 10, 2024
donaldsharp
added a commit
that referenced
this pull request
Aug 10, 2024
mgmtd: don't add implicit state data when reading config from file (backport #16529)
donaldsharp
added a commit
that referenced
this pull request
Aug 10, 2024
mgmtd: don't add implicit state data when reading config from file (backport #16529)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mgmt reads configuration from file, it shouldn't add implicit state data to the candidate datastore. Configuration datastores like candidate should never store state, otherwise they fail validation.
Fixes #15814