Fix LYD_NEW_PATH_OUTPUT issue to support libyang v3.x

[oplklum]

There will be a LYD_NEW_PATH_OUTPUT undeclared error if using the latest libyang V3.x version. It was reported in #16287 before.
I fixed the error to support that. And it's compatible with old version.

lib/yang.c: In function ‘yang_dnode_rpc_output_add’:
lib/yang.c:674:7: error: ‘LYD_NEW_PATH_OUTPUT’ undeclared (first use in this function); did you mean ‘LYD_NEW_VAL_OUTPUT’?
674 | LYD_NEW_PATH_OUTPUT | LYD_NEW_PATH_UPDATE, NULL);
| ^~~~~~~~~~~~~~~~~~~
| LYD_NEW_VAL_OUTPUT
lib/yang.c:674:7: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:10793: lib/yang.lo] Error 1
make[1]: Leaving directory '/opt/frr'
make: *** [Makefile:6576: all] Error 2

[donaldsharp]

Please let's follow our style conventions for commit messages. Read doc/developer/workflow.rst for the how to.

[oplklum]

Please let's follow our style conventions for commit messages. Read doc/developer/workflow.rst for the how to.

Thanks for your reminding👌

[choppsv1]

let's use #16514 instead it keeps the libyang3 conditionals together and also deals with the change not being correct (i guess early libyang v3 didn't have/require this change?)

[riw777]

Aug 4, 2024

does this need to be closed?

[choppsv1]

@oplklum we could also use your PR if you'd like to update your change to match #16514. I hadn't seen your fix when I submitted mine.

[vjardin]

does this need to be closed?

Let's give an opportunity to @oplklum to have a contribution on FRR, but this code needs to be updated as it was done by @choppsv1 .

[oplklum]

does this need to be closed?

Let's give an opportunity to @oplklum to have a contribution on FRR, but this code needs to be updated as it was done by @choppsv1 .

Thanks very much to give me the opportunity to contribute FRR, @choppsv1 @vjardin. I feel so happy and respected😁😁😁. Thank you all, great team.

I change the code following @choppsv1's way and I add the define in condition (LY_VERSION_MAJOR < 3). According to the below comment, I think the code can still be compiled fine if we remove the old compatible code in future.

/* Safe to remove after libyang 2.2.8 */
#if (LY_VERSION_MAJOR < 3)

[choppsv1]

https://github.com/Mergifyio backport stable/10.1

[mergify]

backport stable/10.1

✅ Backports have been created

• #16776 Fix LYD_NEW_PATH_OUTPUT issue to support libyang v3.x (backport #16511) has been created for branch stable/10.1