tests: topotests/lib: add wait to RequireVpnRoutes, RequireUnicastRoutes #16492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: G. Paul Ziemba <[email protected]>
paulzlabn
force-pushed
the
ziemba/topotests-lib-bgprib-wait
branch
from
ef528f2 to
460703f
Compare
|
I've tested this locally and it appears to fix the issue I was seeing. I also think this will fix the myriad of occasional test failures we are getting inside of check_routes.py across a slew of tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timing changes in vtysh (PR 16427) affected test results. This change adds retries and timeout to test functions in tests/topotests/lib/bgprib.py (with default values and additional parameters allowing callers to override).