nhrpd: fixes duplicate auth extension #16480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleroy
force-pushed
the
dleroy/nhrpd-duplicate-auth-fix
branch
2 times, most recently
from
f80754e to
fba6f03
Compare
|
Jafaral
reviewed
Jul 26, 2024
nhrpd/nhrp_peer.c
Outdated
| * This will be done below in nhrp_packet_complete_auth(). | ||
| */ | ||
| /* Extensions can be copied from original packet except | ||
| * authentication extension which must be regenerated |
dleroy
force-pushed
the
dleroy/nhrpd-duplicate-auth-fix
branch
from
fba6f03 to
80218f6
Compare
When an NHRP server was forwarding a message, it was copying all extensions from the originally received packet. The authentication extension must be regenerated hop by hop per RFC2332. The copied auth extension had an incorrect length. This fix checks for the auth extension when copying extensions and omits the original packet auth and instead regenerates a new auth extension. Fix bug FRRouting#16466 Signed-off-by: Dave LeRoy <[email protected]>
dleroy
force-pushed
the
dleroy/nhrpd-duplicate-auth-fix
branch
from
80218f6 to
7c20ffa
Compare
|
LGTM once CI passes I will get this in. |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an NHRP server was forwarding a message, it was copying all extensions from the originally received packet. The authentication extension must be regenerated hop by hop per RFC2332. The copied auth extension had an incorrect length. This fix checks for the auth extension when copying extensions and omits the original packet auth and instead regenerates a new auth extension.
Fix bug #16466