isisd: fix building flex-algo asla at init #16467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci:rerun |
odd22
reviewed
Jul 25, 2024
isisd/isis_nb_config.c
Outdated
| if (update_te) { | ||
| for (ALL_LIST_ELEMENTS_RO(area->circuit_list, node, | ||
| circuit)) | ||
| isis_link_params_update(circuit, |
There was a problem hiding this comment.
Why do you not call isis_link_params_update_asla() directly? only flex_algo parameters have been updated and need attention to eventually regenerate the LSP.
There was a problem hiding this comment.
You are right. Changed
I have added the last flex-algo unconfiguration case and some cleanup
louis-6wind
force-pushed
the
fix-flex-algo-asla
branch
from
34d2b8e to
40a136b
Compare
Remove duplicated flex_algos_free prototype Signed-off-by: Louis Scalbert <[email protected]>
Move flex_algo_delete() content into isis_instance_flex_algo_destroy() because it is called only once. Rename _flex_algo_delete to flex_algo_free() Cosmetic change. Signed-off-by: Louis Scalbert <[email protected]>
When an color affinity is set on an interface before configuring the flex-algorithm, the ASLA (Application Specific Link-Attribute) sub-TLV is not build. Flex-algo fails to build the paths when a affinity constraint is required because of the lacking of information contained in ASLA. There are no problems when the configuration order is reversed. For example: > affinity-map red bit-position 1 > > interface eth2 > link-params > affinity red > > router isis 1 > mpls-te on > flex-algo 129 > dataplane sr-mpls > advertise-definition > affinity include-any green In isis_link_params_update_asla(), the ASLA sub-TLV is not build when the list of flex-algos is empty. Update ASLA when the first flex-algorithm is configured. Fixes: 893882e ("isisd: add isis flex-algo configuration backend") Signed-off-by: Louis Scalbert <[email protected]>
Free ASLA when the last flex-algo is unconfigured. Signed-off-by: Louis Scalbert <[email protected]>
louis-6wind
force-pushed
the
fix-flex-algo-asla
branch
from
40a136b to
e3634cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an color affinity is set on an interface before configuring the flex-algorithm, the ASLA (Application Specific Link-Attribute) sub-TLV is not build. Flex-algo fails to build the paths when a affinity constraint is required because of the lacking of information contained in ASLA. There are no problems when the configuration order is reversed. For example:
In isis_link_params_update_asla(), the ASLA sub-TLV is not build when the list of flex-algos is empty.
Update ASLA when the first flex-algorithm is configured.
Fixes: 893882e ("isisd: add isis flex-algo configuration backend")