bfdd: remove obsolete control socket #16463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rzalamena do we need to actually pay attention to frrbot complaints? |
Let's remove the obsolete BFD control socket. If the functionality is needed then YANG/northbound notifications / getting should be used instead. Signed-off-by: Rafael Zalamena <[email protected]>
Signed-off-by: Rafael Zalamena <[email protected]>
Signed-off-by: Rafael Zalamena <[email protected]>
rzalamena
force-pushed
the
bfd-remove-control-socket
branch
from
11651e8 to
c4867fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR obsoletes: #14095 .
The original BFD control socket design was limited and inefficient and now FRR has the northbound with more advance capabilities to provide the same functionality. It is time to retire the code for the control socket which burdens the maintenance.