yang: Corrected range in yang file #16392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:rerun |
1 similar comment
|
CI:rerun |
|
don't know if we need this? @aceelindem is taking a look |
aceelindem
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Strictly speaking, the quotes are not needed for the range as long as there are no embedded spaces, e.g., "1 .. 65535" would require quoting. However, the "pyang -f yang" canonical formatting will quote YANG ranges and all the other ranges in frr-eigrpd.yang are quoted so I'd say go ahead with the change to avoid confusion.
|
CI:rerun |
Corrected range in yang file Signed-off-by: y-bharath14 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected range in yang file