Duplicate fib proposal #16342
Merged
Duplicate fib proposal #16342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci:rerun |
1 similar comment
|
ci:rerun |
pguibert6WIND
force-pushed
the
duplicate_fib_proposal
branch
from
8670338 to
4cea7e7
Compare
pguibert6WIND
force-pushed
the
duplicate_fib_proposal
branch
from
4cea7e7 to
c4cb297
Compare
pguibert6WIND
force-pushed
the
duplicate_fib_proposal
branch
from
c4cb297 to
9f71889
Compare
During the bgp_peer_type_multipath_relax_test, the test does not check the 'duplicate' flag value of the duplicate nexthop. Fix this by adding the duplicate value in the expected json files. Fixes: ee88563 ("bgpd: Add 'bgp bestpath peer-type multipath-relax'") Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
duplicate_fib_proposal
branch
from
9f71889 to
f328bbb
Compare
The bgp_duplicate_nexthop test installs routes with nexthop's flags set to both DUPLICATE and FIB: this should not happen. The DUPLICATE flag of a nexthop indicates this nexthop is already used in the same nexthop-group, and there is no need to install it twice in the system; having the FIB flag set indicates that the nexthop is installed in the system. This is why both flags should not be set on the same nexthop. This case happens at installation time, but can also happen at update time. - Fix this by not setting the FIB flag value when the DUPLICATE flag is present. - Modify the bgp_duplicate_test to check that the FIB flag is not present on duplicated nexthops. - Modify the bgp_peer_type_multipath_relax test. Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
duplicate_fib_proposal
branch
from
f328bbb to
731f74e
Compare
|
|
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Jul 8, 2024
The bgp_duplicate_nexthop test installs routes with nexthop's flags set to both DUPLICATE and FIB: this should not happen. The DUPLICATE flag of a nexthop indicates this nexthop is already used in the same nexthop-group, and there is no need to install it twice in the system; having the FIB flag set indicates that the nexthop is installed in the system. This is why both flags should not be set on the same nexthop. This case happens at installation time, but can also happen at update time. - Fix this by not setting the FIB flag value when the DUPLICATE flag is present. - Modify the bgp_duplicate_test to check that the FIB flag is not present on duplicated nexthops. - Modify the bgp_peer_type_multipath_relax test. Link: FRRouting#16342 Signed-off-by: Philippe Guibert <[email protected]>
|
|
|
@riw777 You probably didn't mean to mention me. I have nothing to do with this project :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For route updates: