Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Set last reset reason to admin shutdown if it was manually #16242

Merged

Conversation

ton31337
Copy link
Member

Closes #16238

Before this patch, we always printed the last reason "Waiting for OPEN", but
if it's a manual shutdown, then we technically are not waiting for OPEN.

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337
Copy link
Member Author

@Mergifyio backport dev/10.1 stable/10.0 stable/9.1 stable/9.0

Copy link

mergify bot commented Jun 19, 2024

backport dev/10.1 stable/10.0 stable/9.1 stable/9.0

✅ Backports have been created

…ailed peer

Before:

```
Neighbor        EstdCnt DropCnt ResetTime Reason
127.0.0.1             0       0     never  Waiting for peer OPEN (n/a)
```

After:

```
Neighbor        EstdCnt DropCnt ResetTime Reason
127.0.0.1             0       0     never Waiting for peer OPEN (n/a)
```

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337 ton31337 added this to the 10.1 milestone Jun 20, 2024
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit 875f1ac into FRRouting:master Jun 24, 2024
10 checks passed
Jafaral added a commit that referenced this pull request Jun 25, 2024
bgpd: Set last reset reason to admin shutdown if it was manually (backport #16242)
Jafaral added a commit that referenced this pull request Jun 25, 2024
bgpd: Set last reset reason to admin shutdown if it was manually (backport #16242)
ton31337 added a commit that referenced this pull request Jun 25, 2024
bgpd: Set last reset reason to admin shutdown if it was manually (backport #16242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid reason bgp
2 participants