isisd: The neighbor entry still displays the deleted hostname of the neighbor. #16241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baozhen-H3C
force-pushed
the
202406191740
branch
from
6bb6197 to
97201a0
Compare
|
Seems that tests should be updated/fixed too. |
Yes, I am currently investigating why the hostname entry is being lost in the case of the |
baozhen-H3C
force-pushed
the
202406191740
branch
3 times, most recently
from
2c03758 to
4fd4374
Compare
baozhen-H3C
force-pushed
the
202406191740
branch
from
4fd4374 to
045029e
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
baozhen-H3C
force-pushed
the
202406191740
branch
2 times, most recently
from
e01b761 to
737df2c
Compare
|
@frrbot rereview |
zhou-run
force-pushed
the
202406191740
branch
3 times, most recently
from
7654c31 to
f50e173
Compare
zhou-run
force-pushed
the
202406191740
branch
2 times, most recently
from
f11f703 to
3fb3206
Compare
…neighbor 1. The lsp_update_data() function will check for the presence of the ISIS_TLV_DYNAMIC_HOSTNAME in the LSP, and then call isis_dynhn_insert() to add a hostname entry corresponding to the LSP ID. However, when the ISIS_TLV_DYNAMIC_HOSTNAME is not present in the LSP, the hostname entry corresponding to the LSP ID should also be deleted. 2. The command “show isis neighbor” invokes isis_adj_name() to display the System ID or hostname, but it does not check the area->dynhostname flag. 3. When the LSP expires and is removed, the corresponding hostname entry should also be deleted. 4. The TLV for LSP fragmentation will not contain the hostname and should be skipped. Signed-off-by: zhou-run <[email protected]>
|
failing in ospf; rerunning just the failed tests to see if we can clear them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp_update_data()function will check for the presence of theISIS_TLV_DYNAMIC_HOSTNAMEin the LSP, and then callisis_dynhn_insert()to add a hostname entry corresponding to the LSP ID. However, when theISIS_TLV_DYNAMIC_HOSTNAMEis not present in the LSP, the hostname entry corresponding to the LSP ID should also be deleted.isis_adj_name()to display the System ID or hostname, but it does not check thearea->dynhostnameflag.Signed-off-by: zhou-run [email protected]