isisd: Even after configuring "no hostname dynamic", the topology still displays the hostname. #16232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baozhen-H3C
force-pushed
the
202406171755
branch
from
002e4fe to
7d89d44
Compare
baozhen-H3C
force-pushed
the
202406171755
branch
from
02edd43 to
804d56f
Compare
Done. |
donaldsharp
reviewed
Jun 18, 2024
isisd/isisd.h
Outdated
| @@ -285,10 +285,12 @@ void isis_area_add_circuit(struct isis_area *area, | |||
| void isis_area_del_circuit(struct isis_area *area, | |||
| struct isis_circuit *circuit); | |||
|
|
|||
| void delete_area_addr(void *arg); | |||
There was a problem hiding this comment.
let's rename this function to be inline with the exposed function names.
There was a problem hiding this comment.
Rename delete_area_addr() to isis_area_address_delete().
donaldsharp
requested changes
Jun 18, 2024
|
The signed off line does not match the name and email address above. I would expect that they should be matching. |
baozhen-H3C
force-pushed
the
202406171755
branch
from
65e1f9f to
0db4699
Compare
…ll displays the hostname. The command "show isis topology" calls print_sys_hostname() to display the system ID or hostname, but it does not check the area->dynhostname flag. Signed-off-by: zhou-run <[email protected]>
Done. |
Done. |
|
@ton31337 can you unblock this? :-) |
it's unblocked 🙂 |
donaldsharp
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command "show isis topology" calls
print_sys_hostname()to display the system ID or hostname, but it does not check thearea->dynhostnameflag.Signed-off-by: zhou-run [email protected]