tests: Avoid importing unused modules #16227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
requested changes
Jun 17, 2024
tests/topotests/lib/bgp.py
Outdated
| @@ -1012,7 +1012,7 @@ def __create_bgp_unicast_address_family( | |||
| for peer_name, peer_dict in deepcopy(neigh_data).items(): | |||
| for dest_link, peer in peer_dict["dest_link"].items(): | |||
| deactivate = None | |||
| activate = None | |||
| activate = None | |||
There was a problem hiding this comment.
Drop this change please.
Hi Donatas Abraitis,
Addressed review comment.
Thanks & Regards,
Bharath
y-bharath14
force-pushed
the
srib-topotest-e
branch
from
ab3588a to
5ae21f5
Compare
Signed-off-by: y-bharath14 <[email protected]>
y-bharath14
force-pushed
the
srib-topotest-e
branch
from
9b2a2c2 to
8381dbd
Compare
ton31337
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: Avoid importing unused modules at test suites
There is no issue / failures with the test suites
For code maintainability, removing unused modules.