Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Convert over to using vrf name instead of id #16223

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

donaldsharp
Copy link
Member

Use the name for when putting out debugs in bgp_zebra.c. Additionally add an evpn flag for announce_route_actual.

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just maybe we can remove VRF keyword for some output because bgp->name_pretty has VRF/view itself.

api.instance, &api.prefix, buf, nhtype, ifindex,
api.metric, api.distance, api.tag);
zlog_debug("Rx route ADD VRF %s %s[%d] %pFX nexthop %s (type %d if %u) metric %u distance %u tag %" ROUTE_TAG_PRI,
bgp->name_pretty,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would lead to the output of something like VRF VRF default (double VRF), maybe we can strip VRF then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Use the name for when putting out debugs in bgp_zebra.c.
Additionally add an evpn flag for announce_route_actual.

Signed-off-by: Donald Sharp <[email protected]>
@ton31337 ton31337 merged commit 86d2466 into FRRouting:master Jun 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants