Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: suppress unused variables at topotests #16202

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

y-bharath14
Copy link
Contributor

tests: suppress unused variables at topotests

There is no issue / failures with the test suites
For code maintainability, suppressed unused variables with "_"

For code maintainability, suppressed unused variables with "_"

Signed-off-by: y-bharath14 <[email protected]>
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question though: is this something like automated work (linter, etc.) or did you do it manually? My point is maybe we could catch such things when the PRs are open?

@y-bharath14
Copy link
Contributor Author

One question though: is this something like automated work (linter, etc.) or did you do it manually? My point is maybe we could catch such things when the PRs are open?

Hi Donatas Abraitis,

I did it manually.
Yeah... As you said we can run linter on the test suites to catch such issues / warnings.
We can run linter on the specific test suite before creating PRs.

Thanks & Regards,
Bharath

@ton31337 ton31337 merged commit e8ce036 into FRRouting:master Jun 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants