bgpd: Do not start BGP session if BFD profile is in shutdown state #16194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjstapp
reviewed
Jun 11, 2024
…state Signed-off-by: Donatas Abraitis <[email protected]>
When we receive a hard-reset notification, we always show it if it was a hard, or not. For sending side, we missed that. Let's display it too. Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/bfd_profile_shutdown
branch
from
0739e59 to
eaaadf5
Compare
2 tasks
mjstapp
reviewed
Jun 11, 2024
ton31337
force-pushed
the
fix/bfd_profile_shutdown
branch
from
eaaadf5 to
79368f8
Compare
mjstapp
approved these changes
Jun 11, 2024
pbrisset
reviewed
Jun 11, 2024
ton31337
force-pushed
the
fix/bfd_profile_shutdown
branch
2 times, most recently
from
11a488d to
83c22b6
Compare
|
Hi, I just try the latest fix on my system and I believe this is working as expected. Thanks you so much for this prompt answer. |
If we do: ``` bfd profile foo shutdown ``` The session is dropped, but immediately established again because we don't have a proper check on BFD. If BFD is administratively shutdown, ignore starting the session. Fixes: FRRouting#16186 Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/bfd_profile_shutdown
branch
from
83c22b6 to
1fb48f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.