yang: fix wrong check for isis metric style #16188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:rerun |
Before: ``` anlan(config)# route isis ix anlan(config-router)# metric-style transition ... anlan(config-if)# isis metric 200 % Configuration failed. Error type: validation Error description: YANG error(s): Path: Data location "/frr-interface:lib/interface[name='x']/frr-isisd:isis/metric/level-1". Error: Must condition ". < 64 or /frr-isisd:isis/instance[area-tag = current()/../../area-tag]/metric-style = 'wide' or not(/frr-isisd:isis/instance[area-tag = current()/../../area-tag]/metric-style)" not satisfied. Path: Data location "/frr-interface:lib/interface[name='x']/frr-isisd:isis/metric/level-2". Error: Must condition ". < 64 or /frr-isisd:isis/instance[area-tag = current()/../../area-tag]/metric-style = 'wide' or not(/frr-isisd:isis/instance[area-tag = current()/../../area-tag]/metric-style)" not satisfied ``` After: ``` anlan(config)# route isis ix anlan(config-router)# metric-style transition ... anlan(config-if)# isis metric 200 anlan(config-if)# ``` Signed-off-by: anlan_cs <[email protected]>
anlancs
force-pushed
the
isisd/fix-metric-style
branch
from
7dd2dbe to
ad1244f
Compare
|
Do you check that the yang model behave correctly in all situation? I mean < 64 if metric is not specified or equal to narrow, and greater or lower than 64 for wide or transition? |
|
Yes, i have tested/passed all related cases locally. @odd22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: