-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmtd: add notification selection to front-end API #16184
Merged
Jafaral
merged 8 commits into
FRRouting:master
from
LabNConsulting:chopps/fe-notify-select
Jun 13, 2024
Merged
mgmtd: add notification selection to front-end API #16184
Jafaral
merged 8 commits into
FRRouting:master
from
LabNConsulting:chopps/fe-notify-select
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
choppsv1
commented
Jun 6, 2024
•
edited
Loading
edited
- Add new notification select message for front-end clients
- Add new native session-req and session-reply replacements for front-end protobuf messages
- Extend fe_client to support new native notify select and session-req messages
- Add topotest
- Add string array encoding/decode to native messages
- `darr_free_free` to `darr_free` each element prior to `darr_free` the array. - `darr_free_func` to call `func` on each element prior to `darr_free` the array. Signed-off-by: Christian Hopps <[email protected]>
Signed-off-by: Christian Hopps <[email protected]>
Signed-off-by: Christian Hopps <[email protected]>
Signed-off-by: Christian Hopps <[email protected]>
Signed-off-by: Christian Hopps <[email protected]>
Signed-off-by: Christian Hopps <[email protected]>
choppsv1
force-pushed
the
chopps/fe-notify-select
branch
from
June 7, 2024 02:40
b30acaa
to
56ce198
Compare
This addition allows for a limited native-message-only front-end interaction. Signed-off-by: Christian Hopps <[email protected]>
Use this to test new native message format for creating sessions. Signed-off-by: Christian Hopps <[email protected]>
choppsv1
force-pushed
the
chopps/fe-notify-select
branch
from
June 11, 2024 14:37
8e13e96
to
27e3694
Compare
Jafaral
changed the title
add notification selection to front-end API
mgmtd: add notification selection to front-end API
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.