Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isisd: fix 'show isis route prefix-sid backup' command #16179

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

pguibert6WIND
Copy link
Member

It is not possible to dump both backup and prefix-sid information. Fix this by authorising it.

rt1# show isis route prefix-sid backup
Area 1:
IS-IS paths to level-1 routers that speak IP
Vertex Type Metric Next-Hop Interface Parent
rt1
10.12.0.0/24 IP internal 0 rt1(4)
10.13.0.0/24 IP internal 0 rt1(4)
1.1.1.1/32 IP internal 0 rt1(4)
rt2 TE-IS 10 rt2 eth-rt2 rt1(4)
rt3 TE-IS 10 rt3 eth-rt3 rt1(4)
10.12.0.0/24 IP TE 20 rt2 eth-rt2 rt2(4)
10.23.0.0/24 IP TE 20 rt2 eth-rt2 rt2(4)
rt3 eth-rt3 rt3(4)
2.2.2.2/32 IP TE 20 rt2 eth-rt2 rt2(4)
10.13.0.0/24 IP TE 20 rt3 eth-rt3 rt3(4)
3.3.3.3/32 IP TE 20 rt3 eth-rt3 rt3(4)

IS-IS L1 IPv4 routing table:

IS-IS paths to level-1 routers that speak IPv6
Vertex Type Metric Next-Hop Interface Parent
rt1
2001:db8:1000::1/128 IP6 internal 0 rt1(4)
rt2 TE-IS 10 rt2 eth-rt2 rt1(4)
rt3 TE-IS 10 rt3 eth-rt3 rt1(4)
2001:db8:1000::2/128 IP6 internal 20 rt2 eth-rt2 rt2(4)
2001:db8:1000::3/128 IP6 internal 20 rt3 eth-rt3 rt3(4)

IS-IS L1 IPv6 routing table:

Fixes: d47d608 ("isisd: refactor handling of SR Prefix-SIDs")

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation also.

@pguibert6WIND pguibert6WIND force-pushed the isis_psid_and_backup branch from f0a820f to 2239662 Compare June 10, 2024 06:48
doc/user/isisd.rst Outdated Show resolved Hide resolved
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than @ton31337 's comment

It is not possible to dump both backup and prefix-sid
information. Fix this by authorising it.

> rt1# show isis route prefix-sid backup
> Area 1:
> IS-IS paths to level-1 routers that speak IP
> Vertex               Type         Metric Next-Hop             Interface Parent
> rt1
> 10.12.0.0/24         IP internal  0                                     rt1(4)
> 10.13.0.0/24         IP internal  0                                     rt1(4)
> 1.1.1.1/32           IP internal  0                                     rt1(4)
> rt2                  TE-IS        10     rt2                  eth-rt2   rt1(4)
> rt3                  TE-IS        10     rt3                  eth-rt3   rt1(4)
> 10.12.0.0/24         IP TE        20     rt2                  eth-rt2   rt2(4)
> 10.23.0.0/24         IP TE        20     rt2                  eth-rt2   rt2(4)
>                                          rt3                  eth-rt3   rt3(4)
> 2.2.2.2/32           IP TE        20     rt2                  eth-rt2   rt2(4)
> 10.13.0.0/24         IP TE        20     rt3                  eth-rt3   rt3(4)
> 3.3.3.3/32           IP TE        20     rt3                  eth-rt3   rt3(4)
>
> IS-IS L1 IPv4 routing table:
>
> IS-IS paths to level-1 routers that speak IPv6
> Vertex               Type         Metric Next-Hop             Interface Parent
> rt1
> 2001:db8:1000::1/128 IP6 internal 0                                     rt1(4)
> rt2                  TE-IS        10     rt2                  eth-rt2   rt1(4)
> rt3                  TE-IS        10     rt3                  eth-rt3   rt1(4)
> 2001:db8:1000::2/128 IP6 internal 20     rt2                  eth-rt2   rt2(4)
> 2001:db8:1000::3/128 IP6 internal 20     rt3                  eth-rt3   rt3(4)
>
> IS-IS L1 IPv6 routing table:
>

Fixes: d47d608 ("isisd: refactor handling of SR Prefix-SIDs")

Signed-off-by: Philippe Guibert <[email protected]>
@pguibert6WIND pguibert6WIND force-pushed the isis_psid_and_backup branch from 2239662 to 7a905c0 Compare June 14, 2024 06:48
@riw777 riw777 merged commit 9eae3cf into FRRouting:master Jun 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants