babel: Added null check after retrieving babel_ifp #16178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjstapp
reviewed
Jun 6, 2024
y-bharath14
force-pushed
the
srib-babel-code-refactoring
branch
2 times, most recently
from
8d948a0 to
269b07f
Compare
Hi Mark Stapp, Since babel_ip NULL check is handled at most of the places in this file. Just to maintain consistency, adding this check at all the places. Thanks & Regards, |
|
can you rebase to see if that clears the ci failures? |
|
Can you please rebase? |
y-bharath14
force-pushed
the
srib-babel-code-refactoring
branch
from
269b07f to
b1c426e
Compare
|
CI:rerun |
@Jafaral , |
@riw777, |
Asserting the further instructions when the babel interface pointer is NULL Signed-off-by: y-bharath14 <[email protected]>
y-bharath14
force-pushed
the
srib-babel-code-refactoring
branch
from
b1c426e to
ae885a7
Compare
|
CI:rerun |
mjstapp
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel: Added null check after retrieving babel_ifp
Asserting the further instructions when the babel interface pointer is NULL