-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zebra: display srv6 encapsulation source-address when configured #16151
Merged
donaldsharp
merged 1 commit into
FRRouting:master
from
pguibert6WIND:srv6_fix_source_address
Jun 6, 2024
Merged
zebra: display srv6 encapsulation source-address when configured #16151
donaldsharp
merged 1 commit into
FRRouting:master
from
pguibert6WIND:srv6_fix_source_address
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'show running-config' does not display the ipv6 source address when a locator is not configured. Fix this by systematically displaying the ipv6 source address. Fixes: 6a09561 ("zebra: Add encap source address to SRv6 config write function") Signed-off-by: Philippe Guibert <[email protected]>
cscarpitta
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch!
LGTM
cscarpitta
added a commit
to cscarpitta/sonic-buildimage
that referenced
this pull request
Dec 16, 2024
This commit brings PR FRRouting/frr#16151 from FRR mainline to SONiC zebra: display srv6 encapsulation source-address when configured FRRouting/frr#16151 Signed-off-by: cscarpitta <[email protected]>
cscarpitta
added a commit
to cscarpitta/sonic-buildimage
that referenced
this pull request
Dec 16, 2024
This commit brings PR FRRouting/frr#16151 from FRR mainline to SONiC zebra: display srv6 encapsulation source-address when configured FRRouting/frr#16151 Signed-off-by: cscarpitta <[email protected]>
cscarpitta
added a commit
to cscarpitta/sonic-buildimage
that referenced
this pull request
Dec 16, 2024
This commit brings PR FRRouting/frr#16151 from FRR mainline to SONiC zebra: display srv6 encapsulation source-address when configured FRRouting/frr#16151 Signed-off-by: cscarpitta <[email protected]>
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
This commit brings PR FRRouting/frr#16151 from FRR mainline to SONiC zebra: display srv6 encapsulation source-address when configured FRRouting/frr#16151 Signed-off-by: cscarpitta <[email protected]>
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
This commit brings PR FRRouting/frr#16151 from FRR mainline to SONiC zebra: display srv6 encapsulation source-address when configured FRRouting/frr#16151 Signed-off-by: cscarpitta <[email protected]>
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
This commit brings PR FRRouting/frr#16151 from FRR mainline to SONiC zebra: display srv6 encapsulation source-address when configured FRRouting/frr#16151 Signed-off-by: cscarpitta <[email protected]>
mssonicbld
added a commit
to mssonicbld/sonic-buildimage-msft
that referenced
this pull request
Jan 7, 2025
#### Why I did it Bring the below PRs from FRR mainline to SONiC in order to support SRv6 SID Manager in SONiC. #### New patches that were added | Patch | FRR Pull Request | | ------------- | ----------------- | | 0064-SRv6-BGP-SID-reachability.patch | FRRouting/frr#14810 | | 0065-zebra-display-srv6-encapsulation-source-address-when-configured.patch | FRRouting/frr#16151 | | 0066-lib-fix-srv6-locator-flags-propagated-to-isis.patch | FRRouting/frr#15673 | | 0067-Add-support-for-SRv6-SID-Manager.patch | FRRouting/frr#15604 | | 0068-bgpd-Extend-BGP-to-communicate-with-the-SRv6-SID-Manager-to-allocate-release-SRv6-SIDs.patch | FRRouting/frr#15676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'show running-config' does not display the ipv6 source address when a locator is not configured. Fix this by systematically displaying the ipv6 source address.
Fixes: 6a09561 ("zebra: Add encap source address to SRv6 config write function")