ospfd: Improve OSPF neighbor retransmission list granularity and pacing #16128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjstapp
reviewed
May 31, 2024
aceelindem
force-pushed
the
aceelindem/ospf-ls-retrans-improve
branch
4 times, most recently
from
829f4df to
2b53be0
Compare
ton31337
reviewed
Jun 4, 2024
aceelindem
force-pushed
the
aceelindem/ospf-ls-retrans-improve
branch
3 times, most recently
from
dea592e to
2c1a581
Compare
|
CI:rerun |
|
not building on docker, but it looks like it's in bfd rather than here ... let's try again ci:rerun |
aceelindem
force-pushed
the
aceelindem/ospf-ls-retrans-improve
branch
2 times, most recently
from
476f653 to
b248c3a
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
aceelindem
force-pushed
the
aceelindem/ospf-ls-retrans-improve
branch
from
b248c3a to
1808e7a
Compare
|
CI:rerun |
2 similar comments
|
CI:rerun |
|
CI:rerun |
…ision
The current OSPF neighbor retransmission operates on a single per-neighbor
periodic timer that sends all LSAs on the list when it expires.
Additionally, since it skips the first retransmission of received LSAs so
that at least the retransmission interval (resulting in a delay of between
the retransmission interval and twice the interval. In environments where
the links are lossy on P2MP networks with "delay-reflood" configured (which
relies on neighbor retransmission in partial meshs), the implementation
is sub-optimal (to say the least).
This commit reimplements OSPF neighbor retransmission as follows:
1. A new data structure making use the application managed
typesafe.h doubly linked list implements an OSPF LSA
list where each node includes a timestamp.
2. The existing neighbor LS retransmission LSDB data structure
is augmented with a pointer to the list node on the LSA
list to faciliate O(1) removal when the LSA is acknowledged.
3. The neighbor LS retransmission timer is set to the expiration
timer of the LSA at the top of the list.
4. When the timer expires, LSAs are retransmitted that within
the window of the current time and a small delta (50 milli-secs
default). The LSAs that are retransmited are given an updated
retransmission time and moved to the end of the LSA list.
5. Configuration is added to set the "retransmission-window" to a
value other than 50 milliseconds.
6. Neighbor and interface LSA retransmission counters are added
to provide insight into the lossiness of the links. However,
these will increment quickly on non-fully meshed P2MP networks
with "delay-reflood" configured.
7. Added a topotest to exercise the implementation on a non-fully
meshed P2MP network with "delay-reflood" configured. The
alternative was to use existing mechanisms to instroduce loss
but these seem less determistic in a topotest.
Signed-off-by: Acee Lindem <[email protected]>
aceelindem
force-pushed
the
aceelindem/ospf-ls-retrans-improve
branch
from
1808e7a to
c494702
Compare
|
CI:rerun |
|
CI:rerun The definition of insanity... |
|
CI:rerun |
|
CI:rerun |
3 similar comments
|
CI:rerun |
|
CI:rerun |
|
CI:rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current OSPF neighbor retransmission operates on a single per-neighbor periodic timer that sends all LSAs on the list when it expires. Additionally, since it skips the first retransmission of received LSAs so that at least the retransmission interval (resulting in a delay of between the retransmission interval and twice the interval. In environments where the links are lossy on P2MP networks with "delay-reflood" configured (which relies on neighbor retransmission in partial meshs), the implementation is sub-optimal (to say the least).
This commit reimplements OSPF neighbor retransmission as follows: