isisd: When operating multiple areas, the system ID behaves abnormally. #16090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baozhen-H3C
force-pushed
the
202405271057
branch
2 times, most recently
from
3f1e9f5 to
5e0c469
Compare
|
How do you test the code before pushing if it's even failing to compile? |
When clearing the net in one of the areas, the system ID is unconditionally cleared, even if the net does not include the current system ID. Signed-off-by: zhou-run <[email protected]> isisd: When operating multiple areas, the system ID behaves abnormally. When deleting one of the areas, even if the net under the area includes the current system ID, the system ID still remains. Signed-off-by: zhou-run <[email protected]> isisd: fix frrbot styling issues found fix frrbot styling issues found Signed-off-by: zhou-run <[email protected]> isisd: fix frrbot styling issues found fix frrbot styling issues found Signed-off-by: zhou-run <[email protected]> isisd: Resolve compilation issues. The higher version updates 'struct area_addr' to 'struct iso_address'. Signed-off-by: zhou-run <[email protected]> isisd: fix frrbot styling issues found fix frrbot styling issues found Signed-off-by: zhou-run <[email protected]>
Sorry, I have now corrected the compilation error. |
ton31337
reviewed
May 28, 2024
|
Possible to verify and test this behavior with topotest? |
riw777
reviewed
May 28, 2024
Hmmm... I don't see a multi-area topo test at all ... I'm okay with letting this go without a topo test since it's a bug fix rather than new functionality, but I'll wait on @ton31337 to answer before pushing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple areas on the same router, the following two scenarios exist:
Signed-off-by: zhou-run [email protected]